Conflict between onionskin and liveview_only #2

Closed
opened 2025-01-20 11:13:39 +01:00 by arthus · 1 comment
Owner

Some weird stuff going on :

  • If you switch to liveview only (key l) and take a picture, it should first re-enable onionskin and disable liveview_only.
  • If you switch to liveview only and try to switch to previous frame only (key 'o') (i.e liveview_only==False && onionskin==False), you then have to hit 'o' a few times to be able to go back to onionskin mode (i.e liveview_only==False && onionskin==True).

The wrong logic is somewhere between L.481 and 501, and L.481-501.

Some weird stuff going on : - If you switch to liveview only (key l) and take a picture, it should first re-enable onionskin and disable liveview_only. - If you switch to liveview only and try to switch to previous frame only (key 'o') (i.e `liveview_only==False && onionskin==False`), you then have to hit 'o' a few times to be able to go back to onionskin mode (i.e `liveview_only==False && onionskin==True`). The wrong logic is somewhere between [L.481 and 501](https://git.arthus.net/arthus/stopi2/src/branch/master/frame_opencv.py#L516), and [L.481-501](https://git.arthus.net/arthus/stopi2/src/branch/master/frame_opencv.py#L516).
arthus added the
Bug
Needs investigation
labels 2025-01-20 11:13:50 +01:00
Author
Owner

I suspect this is resolved due to code overhaul in ab586d29ca.

I suspect this is resolved due to code overhaul in https://git.arthus.net/arthus/stopi2/commit/ab586d29ca2d8e158e2517b53a52107db81c8e28.
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: arthus/stopi2#2
No description provided.